Skip to content

Support copying global selectors & warning dialog before removing #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mournfulCoroner wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support copying global selectors & warning dialog before removing #3237

mournfulCoroner wants to merge 7 commits into from
+322 −106

Conversation

@mournfulCoroner
Copy link
Contributor

@mournfulCoroner mournfulCoroner commented Dec 10, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

E2E Tests

Playwright test results

passed  196 passed
flaky  10 flaky
skipped  2 skipped

Details

stats  208 tests across 113 suites
duration  3 minutes, 35 seconds
commit  9b3a76c

Flaky tests

opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Connector should be created
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Title bg color @screenshot
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Title text color @screenshot
opensource › opensource-suites/wizard/edit-history/basic.test.ts › Wizard › Edit history › Make some changes, then undo them, then redo them
opensource › opensource-suites/wizard/visualizations/bar-y/coloring.test.ts › Wizard › Bar-y chart › Coloring by Measure Values with Measure Names in Y section @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/coloring.test.ts › Wizard › Flat table › Gradient coloring @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/virtualization.test.ts › Wizard › Flat table › Correct order of rows when scrolling @screenshot
opensource › opensource-suites/wizard/visualizations/pie/export.test.ts › Wizard › Pie chart › Export to xlsx
opensource › opensource-suites/wizard/visualizations/pivot-table/totals.test.ts › Wizard › Pivot table › Subtotals for NULL values

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-10 17:55:16 MSK

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

E2E Tests No Auth

Playwright test results

passed  199 passed
flaky  7 flaky
skipped  2 skipped

Details

stats  208 tests across 113 suites
duration  3 minutes, 16 seconds
commit  9b3a76c

Flaky tests

opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/wizard/fields/field-actions.test.ts › Wizard › Fields › Duplicate field
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/bar-y/coloring.test.ts › Wizard › Bar-y chart › Coloring by Measure Values with Measure Names in Y section @screenshot
opensource › opensource-suites/wizard/visualizations/line/preview.test.ts › Wizard › Line chart › Event "chart-preview.done" is triggered after the chart is rendered
opensource › opensource-suites/wizard/visualizations/pivot-table/export.test.ts › Wizard › Pivot table › Export to xlsx

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-10 17:55:01 MSK

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

E2E Tests Farm

Playwright test results

failed  1 failed
passed  415 passed
flaky  9 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  3 minutes, 11 seconds
commit  9b3a76c

Failed tests

basic › suites/wizard/navigation/navigation.test.ts › Wizard - Navigation › When trying to save a chart with the choice of an arbitrary folder in the navigation, the chart is saved successfully

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets

👉 Link with detailed report: report

Last updated: 2025-12-10 17:58:16 MSK

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025 •
edited
Loading

📦 Statoscope quick diff with main-branch:

⏱ Build time: 5.0 sec (10.07%)

⚖️ Initial size: 0.48 kb (0.01%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.group-controls-dialog.edit (ru)
dash.group-controls-dialog.edit (en)
dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Dec 10, 2025

i18n-check

The following components have not been translated

dash.control-dialog.edit (ru)
dash.control-dialog.edit (en)
dash.group-controls-dialog.edit (ru)
dash.group-controls-dialog.edit (en)
dash.main.view (ru)
dash.main.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mournfulCoroner @datalens-weblate-robot