Closed
Conversation
Contributor
We can pin the version in a .nvmrc |
Contributor
Author
Yes but is it useful? Done in 8c16413 |
Contributor
|
Do we really want Node 25 ? Non-LTS are supported only for 6 months. I think we can switch to 24 now and to 26 in a couple of months. |
Contributor
Author
I like updating every 6 months our Node… But as you wish, I do not have strong opinion on the topic |
Contributor
Author
|
Replaced by #1011 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see a sub 12 minutes CI in https://github.com/datagouv/cdata/actions?query=is%3Asuccess but this PR manage to do two runs in 11min59 and 11min38 so there may be some perfs improvements for the production! (and CI)
I've had to do
nvm use 25. Not sure if we have a default somewhere?