Integrate JiT compilation into CLI #2110
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { ChildProcess, fork } from "child_process"; | ||
|
|
||
| export abstract class BaseWorker<TResponse, TMessage = any> { | ||
| protected constructor(private readonly loaderPath: string) {} | ||
|
|
||
| protected async runWorker( | ||
| timeoutMillis: number, | ||
| onBoot: (child: ChildProcess) => void, | ||
| onMessage: (message: TMessage, child: ChildProcess, resolve: (res: TResponse) => void, reject: (err: Error) => void) => void | ||
| ): Promise<TResponse> { | ||
| const forkScript = this.resolveScript(); | ||
| const child = fork(forkScript, [], { | ||
| stdio: [0, 1, 2, "ipc", "pipe"] | ||
| }); | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| let completed = false; | ||
| let booted = false; | ||
|
|
||
| const terminate = (fn: () => void) => { | ||
| if (completed) { | ||
| return; | ||
| } | ||
| completed = true; | ||
| clearTimeout(timeout); | ||
| child.kill(); | ||
| fn(); | ||
| }; | ||
|
|
||
| const timeout = setTimeout(() => { | ||
| terminate(() => | ||
| reject(new Error(`Worker timed out after ${timeoutMillis / 1000} seconds`)) | ||
| ); | ||
| }, timeoutMillis); | ||
|
|
||
| child.on("message", (message: any) => { | ||
| if (message.type === "worker_booted") { | ||
| if (!booted) { | ||
| booted = true; | ||
| onBoot(child); | ||
| } | ||
| return; | ||
| } | ||
| onMessage(message, child, (res) => terminate(() => resolve(res)), (err) => terminate(() => reject(err))); | ||
| }); | ||
|
|
||
| child.on("error", err => { | ||
| terminate(() => reject(err)); | ||
| }); | ||
|
|
||
| child.on("exit", (code, signal) => { | ||
| if (!completed) { | ||
| const errorMsg = | ||
| code !== 0 && code !== null | ||
| ? `Worker exited with code ${code} and signal ${signal}` | ||
| : "Worker exited without sending a response message"; | ||
| terminate(() => reject(new Error(errorMsg))); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| private resolveScript() { | ||
| const pathsToTry = [this.loaderPath, "./worker_bundle.js"]; | ||
| for (const p of pathsToTry) { | ||
| try { | ||
| return require.resolve(p); | ||
| } catch (e) { | ||
| // Continue to next path. | ||
| } | ||
| } | ||
| throw new Error(`Could not resolve worker script. Tried: ${pathsToTry.join(", ")}`); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| import { ChildProcess } from "child_process"; | ||
| import * as path from "path"; | ||
|
|
||
| import { BaseWorker } from "df/cli/api/commands/base_worker"; | ||
| import { handleDbRequest } from "df/cli/api/commands/jit/rpc"; | ||
| import { IDbAdapter, IDbClient } from "df/cli/api/dbadapters"; | ||
| import { IBigQueryExecutionOptions } from "df/cli/api/dbadapters/bigquery"; | ||
| import { DEFAULT_COMPILATION_TIMEOUT_MILLIS } from "df/cli/api/utils/constants"; | ||
| import { dataform } from "df/protos/ts"; | ||
|
|
||
| export interface IJitWorkerMessage { | ||
| type: "rpc_request" | "jit_response" | "jit_error"; | ||
| method?: string; | ||
| request?: Uint8Array; | ||
| correlationId?: string; | ||
| response?: Uint8Array; | ||
| error?: string; | ||
| } | ||
|
|
||
| export class JitCompileChildProcess extends BaseWorker< | ||
| dataform.IJitCompilationResponse, | ||
| IJitWorkerMessage | ||
| > { | ||
| public static async compile( | ||
| request: dataform.IJitCompilationRequest, | ||
| projectDir: string, | ||
| dbadapter: IDbAdapter, | ||
| dbclient: IDbClient, | ||
| timeoutMillis: number = DEFAULT_COMPILATION_TIMEOUT_MILLIS, | ||
| options?: IBigQueryExecutionOptions | ||
| ): Promise<dataform.IJitCompilationResponse> { | ||
| return await new JitCompileChildProcess().run( | ||
| request, | ||
| projectDir, | ||
| dbadapter, | ||
| dbclient, | ||
| timeoutMillis, | ||
| options | ||
| ); | ||
| } | ||
|
|
||
| constructor() { | ||
| super(path.resolve(__dirname, "../../../vm/jit_loader")); | ||
| } | ||
|
|
||
| private async run( | ||
| request: dataform.IJitCompilationRequest, | ||
| projectDir: string, | ||
| dbadapter: IDbAdapter, | ||
| dbclient: IDbClient, | ||
| timeoutMillis: number, | ||
| options?: IBigQueryExecutionOptions | ||
| ): Promise<dataform.IJitCompilationResponse> { | ||
| return await this.runWorker( | ||
| timeoutMillis, | ||
| child => { | ||
| child.send({ | ||
| type: "jit_compile", | ||
| request, | ||
| projectDir | ||
| }); | ||
| }, | ||
| async (message, child, resolve, reject) => { | ||
| if (message.type === "rpc_request") { | ||
| await this.handleRpcRequest(message, child, dbadapter, dbclient, options); | ||
| } else if (message.type === "jit_response") { | ||
| resolve(dataform.JitCompilationResponse.fromObject(message.response)); | ||
| } else if (message.type === "jit_error") { | ||
| reject(new Error(message.error)); | ||
| } | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| private async handleRpcRequest( | ||
| message: IJitWorkerMessage, | ||
| child: ChildProcess, | ||
| dbadapter: IDbAdapter, | ||
| dbclient: IDbClient, | ||
| options?: IBigQueryExecutionOptions | ||
| ) { | ||
| try { | ||
| const response = await handleDbRequest( | ||
| dbadapter, | ||
| dbclient, | ||
| message.method, | ||
| message.request, | ||
| options | ||
| ); | ||
| child.send({ | ||
| type: "rpc_response", | ||
| correlationId: message.correlationId, | ||
| response | ||
| }); | ||
| } catch (e) { | ||
| child.send({ | ||
| type: "rpc_response", | ||
| correlationId: message.correlationId, | ||
| error: e.message | ||
| }); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify: in the base worker you have a hook for "exit", they'll be equivalent?