Skip to content

Move DefaultIcebergConfig message to avoid circular dependencies #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apilaskowski wants to merge 4 commits into
base: main
Choose a base branch
from
+18 −19
Open

Move DefaultIcebergConfig message to avoid circular dependencies #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39bba24
Define DefaultIcebergConfig message
apilaskowski Mar 7, 2026
136c9cd
Remove DefaultIcebergConfig message
apilaskowski Mar 7, 2026
95df529
Remove import of configs.proto from core.proto
apilaskowski Mar 7, 2026
a7a211b
Remove unused import from configs.proto
apilaskowski Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions protos/configs.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,6 @@ message WorkflowSettings {
bool disable_assertions = 13;
}

message DefaultIcebergConfig {
// Optional. Bucket name used to construct a storage URI when creating an
// Iceberg table.
string bucket_name = 1;

// Optional. Table folder root used to construct a storage URI when creating
// an Iceberg table.
string table_folder_root = 2;

// Optional. Table folder subpath used to construct a storage URI when
// creating an Iceberg table.
string table_folder_subpath = 3;

// Optional. The connection specifying the credentials to be used to read and
// write to external storage, such as Cloud Storage.
string connection = 4;
}

// Action configs defines the contents of `actions.yaml` configuration files.
message ActionConfigs {
repeated ActionConfig actions = 1;
Expand Down
19 changes: 18 additions & 1 deletion protos/core.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ syntax = "proto3";

package dataform;

import "protos/configs.proto";
import "google/protobuf/struct.proto";

option java_package = "com.dataform.protos";
Expand Down Expand Up @@ -36,6 +35,24 @@ message ProjectConfig {
reserved 3, 4, 6, 8, 10, 12, 13;
}

message DefaultIcebergConfig {
Copy link
Copy Markdown
Contributor

@kolina kolina Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you're doing is correct (we shouldn't have done this in the first place), but technically it's a breaking change

Copy link
Copy Markdown
Collaborator Author

@apilaskowski apilaskowski Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolina should we leave it as is, or can we introduce this change (I can work around this if we prefer to have it as is).

Copy link
Copy Markdown
Contributor

@kolina kolina Mar 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change be wire-compatible? i.e. can the new client read the old compilation result protobuf and the old client read the new compilation result?

I would be ok to do this change, but we need to make sure that it won't break runtime interaction

// Optional. Bucket name used to construct a storage URI when creating an
// Iceberg table.
string bucket_name = 1;

// Optional. Table folder root used to construct a storage URI when creating
// an Iceberg table.
string table_folder_root = 2;

// Optional. Table folder subpath used to construct a storage URI when
// creating an Iceberg table.
string table_folder_subpath = 3;

// Optional. The connection specifying the credentials to be used to read and
// write to external storage, such as Cloud Storage.
string connection = 4;
}

message CompileConfig {
// Required.
string project_dir = 1;
Expand Down
Loading