Skip to content

Feature/(No Emoji)i18n enhancement#284

Open
liaozip wants to merge 9 commits intodataelement:mainfrom
liaozip:feature/ui-i18n-enhancement
Open

Feature/(No Emoji)i18n enhancement#284
liaozip wants to merge 9 commits intodataelement:mainfrom
liaozip:feature/ui-i18n-enhancement

Conversation

@liaozip
Copy link
Copy Markdown
Contributor

@liaozip liaozip commented Apr 3, 2026

已完成的工作:

  1. ✅ 从 zh.json 中移除了所有 Emoji(如 📊、🔧、🤖、🌐、📅、⚡、⚙️、🏢、🔐、📧、👥、↩、✅、❌ 等)
  2. ✅ 从 en.json 中移除了所有 Emoji
  3. ✅ 保留了所有中文和英文文本内容
  4. ✅ 提交并推送到远程仓库
    修改示例:
  • "llmCallsToday": "🤖 今日 LLM 调用" → "llmCallsToday": "今日 LLM 调用"
  • "totalToken": "📊 总 Token" → "totalToken": "总 Token"
  • "tools": "🔧 工具" → "tools": "工具"
  • "skills": "⚡ 技能" → "skills": "技能"
  • "settings": "⚙️ 设置" → "settings": "设置"

Copy link
Copy Markdown
Contributor

@wisdomqin wisdomqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @liaozip! The work is solid — particularly the emoji cleanup and replacing hardcoded strings with t() calls across components. A few notes before we can merge:

Conflicts — This PR is currently dirty (conflicts with main). We've had significant changes to AgentDetail.tsx, en.json, and zh.json since your branch was created. A rebase is required.

Scope concerns — I'd like to separate a few items:

  1. skillNames / skillDescriptions in i18n — Preset skill content (Designer, Market Researcher descriptions, boundaries, etc.) should live in dedicated skill files, not in JSON translation files. Mixing business content with UI strings makes both harder to maintain. Please remove this section and we can handle it separately.

  2. Email template defaults in AdminCompanies.tsx — Embedding full email body text as i18n keys is a pattern we want to avoid. The backend already provides d.defaults for this. The simpler fix is just setEmailTemplates({ ...d.defaults, ...d.templates }) — let's keep the logic there.

  3. UserManagement Platform Admin badge — The \n + whiteSpace: pre-line approach for wrapping role labels feels fragile. Leave the label as a single line for now.

What we definitely want:

  • Emoji removal from i18n ✓
  • Hardcoded → t() in AgentDetail.tsx, ChannelConfig.tsx, FileBrowser.tsx
  • CopyMessageButton missing useTranslation() fix ✓
  • UserManagement periodLabel i18n refactor ✓
  • .gitignore .trae/ addition ✓

Suggested action: Rebase on main, drop the skillNames/skillDescriptions block and the email template defaults, then push. That should reduce the conflict surface considerably and let us merge quickly.

liaozip and others added 2 commits April 3, 2026 22:39
- Remove skillNames/skillDescriptions from i18n (should be in skill files)
- Simplify email template defaults in AdminCompanies.tsx (use backend defaults)
- Fix UserManagement platform admin badge (remove fragile \n + pre-line approach)
@liaozip
Copy link
Copy Markdown
Contributor Author

liaozip commented Apr 3, 2026

I’ve addressed all the feedback. Here are the changes made:
我已根据反馈完成了所有修改,具体变更如下:

  1. Removed skillNames/skillDescriptions block
  2. 移除 skillNames/skillDescriptions 块
    Removed preset skills content from zh.json and en.json.
    从 zh.json 和 en.json 中移除了预设技能内容。
  3. Fixed email template defaults in AdminCompanies.tsx
  4. 修复 AdminCompanies.tsx 邮件模板默认值
    Simplified loading logic to: setEmailTemplates({ ...d.defaults, ...d.templates }).
    简化了加载逻辑为:setEmailTemplates({ ...d.defaults, ...d.templates })。
    Simplified the reset function to use backend-provided emailTemplateDefaults.
    简化了重置功能,使用后端提供的 emailTemplateDefaults。
    Removed the Subject/Body default values from i18n files.
    移除了 i18n 文件中的 Subject/Body 默认值。
  5. Fixed UserManagement Platform Admin badge
  6. 修复 UserManagement 平台管理员徽章
    Removed the fragile \n + whiteSpace: pre-line approach.
    移除了脆弱的 \n + whiteSpace: pre-line 方式。
    Switched to a single-line display for “Platform Admin”.
    改为单行显示 “Platform Admin”。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants