Skip to content

fix: Unauthenticated Arbitrary File Upload in SQLBot uploadExcel Endp… #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaJunjie2020 merged 1 commit into from
Dec 8, 2025
Merged

fix: Unauthenticated Arbitrary File Upload in SQLBot uploadExcel Endp… #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/common/utils/whitelist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"/system/assistant/info/*",
"/system/assistant/app/*",
"/system/assistant/picture/*",
"/datasource/uploadExcel",
"/system/authentication/platform/status",
"/system/authentication/login/*",
"/system/authentication/sso/*",
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/views/ds/DatasourceForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { setSize } from '@/utils/utils'
import EmptyBackground from '@/views/dashboard/common/EmptyBackground.vue'
import icon_fileExcel_colorful from '@/assets/datasource/icon_excel.png'
import IconOpeDelete from '@/assets/svg/icon_delete.svg'
import { useCache } from '@/utils/useCache'

const props = withDefaults(
defineProps<{
Expand Down Expand Up @@ -128,6 +129,10 @@ const close = () => {
saveLoading.value = false
}

const { wsCache } = useCache()
const token = wsCache.get('user.token')
const headers = ref<any>({ 'X-SQLBOT-TOKEN': `Bearer ${token}` })

const initForm = (item: any, editTable: boolean = false) => {
isEditTable.value = false
keywords.value = ''
Expand Down Expand Up @@ -539,6 +544,7 @@ defineExpose({
v-if="form.filename && !form.id"
class="upload-user"
accept=".xlsx,.xls,.csv"
:headers="headers"
:action="getUploadURL"
:before-upload="beforeUpload"
:on-error="onError"
Expand All @@ -554,6 +560,7 @@ defineExpose({
v-else-if="!form.id"
class="upload-user"
accept=".xlsx,.xls,.csv"
:headers="headers"
:action="getUploadURL"
:before-upload="beforeUpload"
:on-success="onSuccess"
Expand Down