Skip to content

Automated Integration Test Goldens Update from CI#6192

Open
datacommons-robot-author wants to merge 1 commit intomasterfrom
nl-golden-update-12165c74-e003-4f28-929a-8b69788f44dc
Open

Automated Integration Test Goldens Update from CI#6192
datacommons-robot-author wants to merge 1 commit intomasterfrom
nl-golden-update-12165c74-e003-4f28-929a-8b69788f44dc

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and beets and removed request for a team April 9, 2026 18:18
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a cleanup of integration test golden files. The primary focus is to standardize place name representations across multiple configuration files and debug outputs, ensuring consistent naming conventions throughout the test suite.

Highlights

  • Standardized Place Names: Updated various chart configurations and debug files to use 'United States' instead of 'United States of America' for consistency.
  • Data Correction: Corrected minor data inconsistencies in integration test files, including updating facet IDs and refining place name formatting for international entities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale update of integration test data, primarily focusing on standardizing place names within chart configuration files. The most significant changes involve renaming "United States of America" to "United States" and "New York City" to "New York," alongside the removal of "district" and "Province" suffixes from various international administrative areas. The PR also includes minor adjustments to facet IDs, statistical variable keys, and result counts in chart titles. I have no feedback to provide.

github-merge-queue bot pushed a commit to datacommonsorg/mixer that referenced this pull request Apr 10, 2026
Rollback place import to revert place names changes in
datacommonsorg/website#6192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant