Add support for DC_INSTRUCTIONS_DIR in Docker convenience script#6185
Merged
kmoscoe merged 102 commits intodatacommonsorg:masterfrom Apr 15, 2026
Merged
Add support for DC_INSTRUCTIONS_DIR in Docker convenience script#6185kmoscoe merged 102 commits intodatacommonsorg:masterfrom
kmoscoe merged 102 commits intodatacommonsorg:masterfrom
Conversation
…'t require custom builds
This reverts commit 6c875ed.
This reverts commit 74eb475.
kmoscoe
changed the title
kmoscoe
requested review from
clincoln8 and
keyurva
and removed request for
keyurva
clincoln8
reviewed
Apr 15, 2026
Contributor
clincoln8
left a comment
clincoln8
left a comment
There was a problem hiding this comment.
Thanks Kara! Just want to make sure that deletion is intentional.
Co-authored-by: Christie Ellks <calinc@google.com>
…a function to use the same logic.
clincoln8
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the run_cdc_dev_docker.sh script to enable both local and GCS paths for custom instructions
I've tested it running all types of run flags (release, latest, custom build) as well as different settings in the env.list file (local and remote gs paths).