Skip to content

Update Saint Martin name in custom DC test goldens#6154

Draft
juliawu wants to merge 2 commits intodatacommonsorg:masterfrom
juliawu:update-saint-martin-name
Draft

Update Saint Martin name in custom DC test goldens#6154
juliawu wants to merge 2 commits intodatacommonsorg:masterfrom
juliawu:update-saint-martin-name

Conversation

@juliawu
Copy link
Copy Markdown
Contributor

@juliawu juliawu commented Mar 31, 2026

We've been getting alerts about failing custom DC tests, that are a result of the V2 APIs returning "Saint Martin" for the name of dcid country/MFA instead of "Saint Martin (French part)". This PR updates the goldens to match V2 api behavior, which will be needed after the next data release.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses failing integration tests caused by a discrepancy between the expected and actual naming conventions returned by the V2 APIs. By updating the test goldens, the suite now correctly reflects the current API behavior, ensuring test stability and resolving ongoing alerts.

Highlights

  • Golden File Update: Updated the expected name for Saint Martin (country/MAF) in the custom DC test configuration to align with V2 API output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the display name for the entity with DCID 'country/MAF' from 'Saint Martin (French part)' to 'Saint Martin' in the integration test configuration file. There are no review comments to address, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant