Update Saint Martin name in custom DC test goldens#6154
Update Saint Martin name in custom DC test goldens#6154juliawu wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses failing integration tests caused by a discrepancy between the expected and actual naming conventions returned by the V2 APIs. By updating the test goldens, the suite now correctly reflects the current API behavior, ensuring test stability and resolving ongoing alerts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the display name for the entity with DCID 'country/MAF' from 'Saint Martin (French part)' to 'Saint Martin' in the integration test configuration file. There are no review comments to address, and I have no feedback to provide.
We've been getting alerts about failing custom DC tests, that are a result of the V2 APIs returning "Saint Martin" for the name of dcid country/MFA instead of "Saint Martin (French part)". This PR updates the goldens to match V2 api behavior, which will be needed after the next data release.