Skip to content

[Service Health] CDC Autopush tagged for Service Health#6148

Open
gmechali wants to merge 2 commits intodatacommonsorg:masterfrom
gmechali:cdctags
Open

[Service Health] CDC Autopush tagged for Service Health#6148
gmechali wants to merge 2 commits intodatacommonsorg:masterfrom
gmechali:cdctags

Conversation

@gmechali
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the deployment of the 'dc-autopush' service to a Cloud Build-based workflow. By moving the deployment logic into a dedicated configuration file, the process becomes more standardized and secure, while also leveraging native build identifiers for better audit trails of service updates.

Highlights

  • Migration to Cloud Build: Updated the deployment process to use Google Cloud Build instead of direct gcloud commands for improved security and auditability.
  • Dynamic Environment Variables: Replaced the local date-based RESTART_TIMESTAMP with a dynamic $BUILD_ID provided by Cloud Build to better track service revisions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the deployment of the dc-autopush Cloud Run service to a Cloud Build-based workflow by adding a new YAML configuration and updating the deployment script. The review feedback identifies a bug in the environment variable expansion for RESTART_TIMESTAMP and suggests using the --no-source flag during build submission to improve efficiency.

- '--region'
- 'us-central1'
- '--update-env-vars'
- 'RESTART_TIMESTAMP=$BUILD_ID'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Use the Cloud Build substitution syntax ${BUILD_ID} to ensure the variable is expanded by the Cloud Build service. Since the gcloud entrypoint does not invoke a shell to process arguments, using $BUILD_ID will result in the literal string "$BUILD_ID" being set as the environment variable value in Cloud Run, which breaks the intended audit functionality.

      - 'RESTART_TIMESTAMP=${BUILD_ID}'

--image gcr.io/datcom-ci/datacommons-services:latest \
--region us-central1 \
--update-env-vars RESTART_TIMESTAMP="$(date)"
gcloud builds submit --config build/ci/cloudbuild.deploy_cdc_autopush.yaml --project datcom-ci .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the Cloud Build configuration only performs a deployment using a pre-existing container image and does not require any files from the local repository, you can use the --no-source flag. This avoids the unnecessary overhead of zipping and uploading the entire directory to Google Cloud Storage.

Suggested change
gcloud builds submit --config build/ci/cloudbuild.deploy_cdc_autopush.yaml --project datcom-ci .
gcloud builds submit --config build/ci/cloudbuild.deploy_cdc_autopush.yaml --project datcom-ci --no-source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant