Feature/image vulnerablities fixes#6088
Feature/image vulnerablities fixes#6088shree1988 wants to merge 16 commits intodatacommonsorg:masterfrom
Conversation
CVE-2026-24049(Wheel), CVE-2026-23949(Jaraco-context), CVE-2026-21441, CVE-2025-66418, CVE-2025-66471 vunerabilites fixes
CVE-2026-24049(Wheel), CVE-2026-23949(Jaraco-context), CVE-2026-21441, CVE-2025-66418, CVE-2025-66471, CVE-2026-25990(pillow), CVE-2026-2472 and CVE-2026-2472(google-cloud-aiplatform) vunerabilites fixes
Removing apt-get upgrade upgrade to reduce image size
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security posture of the application by addressing identified image vulnerabilities. It achieves this by updating various Python dependencies and core packaging tools across two Docker images, Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix image vulnerabilities by upgrading several Python packages in the Dockerfiles. The changes are reasonable, but I have identified a few areas for improvement regarding Docker image optimization best practices and a potential dependency version inconsistency that should be addressed.
Updated pip install command to use --no-cache-dir option for better caching control.
Refactor pip install command to use no-cache-dir option and remove unnecessary cleanup commands.
Upgrade pip, setuptools, and wheel during virtual environment creation.
| RUN chmod +x run.sh | ||
|
|
||
| # Python packages upgrade to fix vulnerabilities | ||
| RUN pip3 install --upgrade --no-cache-dir \ |
There was a problem hiding this comment.
Rather than putting these version inline in the docker image, can they be moved to a requirements.txt file?
There was a problem hiding this comment.
Hi @dwnoble, I encountered a conflict error after adding it to the requirements.txt file; however, upgrading the package in the Dockerfile worked as expected.
No description provided.