-
Notifications
You must be signed in to change notification settings - Fork 138
Climate trace ghg emission - manifest file correction #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarishC727
wants to merge
21
commits into
datacommonsorg:master
Choose a base branch
from
HarishC727:climate_trace_ref
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−16
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
416c26c
Climate Trace GHG Emissions refresh
HarishC727 15b2c25
resolved gemini comments
HarishC727 6b45269
Merge branch 'master' into climate_trace_ref
HarishC727 a17f6ee
Merge branch 'master' into climate_trace_ref
HarishC727 3593055
Merge branch 'master' into climate_trace_ref
HarishC727 be09dc6
resolved internal comments
HarishC727 b6a6327
Merge branch 'master' into climate_trace_ref
HarishC727 26f9e4b
resolved core team comments
HarishC727 f38f4e7
Merge branch 'master' into climate_trace_ref
HarishC727 e8e6310
updated readme
HarishC727 3c4068c
fixed manifest file
HarishC727 cdc2f74
Merge branch 'master' into climate_trace_ref
HarishC727 37e0136
Merge branch 'master' into climate_trace_ref
HarishC727 674a850
Remove input_rows from common_metadata.csv
HarishC727 8b5922a
Merge branch 'master' into climate_trace_ref
HarishC727 b5a0d28
Merge branch 'datacommonsorg:master' into climate_trace_ref
HarishC727 75f84a9
correcting manifest.json
HarishC727 0169212
fixed download
HarishC727 a70c829
Merge branch 'master' into climate_trace_ref
HarishC727 8771365
Merge branch 'master' into climate_trace_ref
HarishC727 748bbaa
Merge branch 'master' into climate_trace_ref
HarishC727 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
import_name'ClimateTrace_GHG_Emissions' mixes PascalCase and underscores. For better code consistency, it's recommended to stick to a single naming convention. Since the original part 'ClimateTrace' is in PascalCase, consider usingClimateTraceGhgEmissionsfor the entire name to follow the same convention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import name already exist and cannot be changed