Upgrade: Rails 7.2 → 8.1 & Ruby 3.2.9 → 4.0.1#196
Open
kaysiz wants to merge 10 commits into
Open
Conversation
jrhoads
approved these changes
May 28, 2026
Contributor
richardhallett
left a comment
richardhallett
left a comment
There was a problem hiding this comment.
Overall looks good, I think i'm a little unsure of the request_encoding change, but might be fine.
| end | ||
|
|
||
| if exists && params[:compressed].present? | ||
| if exists && request_encoding == "gzip" |
Contributor
There was a problem hiding this comment.
I guess this will work, but is the request_encoding method always returning a string "gzip" for the various options?
I'm a little unsure about changing it from the check on the param :compressed, though that might end up being the same?
| # config.action_mailer.perform_caching = false | ||
| # Log to STDOUT with the current request id as a default log tag. | ||
| config.log_tags = [ :request_id ] | ||
| config.logger = ActiveSupport::TaggedLogging.logger(STDOUT) |
Contributor
There was a problem hiding this comment.
This will override the lograge setup in application.rb
| # Set this to true and configure the email server for immediate delivery to raise delivery errors. | ||
| # config.action_mailer.raise_delivery_errors = false | ||
| # Change to "debug" to log everything (including potentially personally-identifiable information!). | ||
| config.log_level = ENV.fetch("RAILS_LOG_LEVEL", "info") |
Contributor
There was a problem hiding this comment.
See above, set at the application.rb file, env var is different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: