Skip to content

Use loop_df columns instead of left_loop and right_loop#265

Merged
ShebMichel merged 2 commits intodatacarpentry:mainfrom
abostroem:fix_episode8
Dec 12, 2025
Merged

Use loop_df columns instead of left_loop and right_loop#265
ShebMichel merged 2 commits intodatacarpentry:mainfrom
abostroem:fix_episode8

Conversation

@abostroem
Copy link
Copy Markdown
Contributor

The lesson used left_loop and right_loop which are not saved to the loop_df variable and therefore not defined when starting from this episode. This updates the plotting to use the values from loop_df.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/astronomy-python/compare/md-outputs..md-outputs-PR-265

The following changes were observed in the rendered markdown documents:

 08-plot.md | 6 ++----
 md5sum.txt | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-12-11 18:22:01 +0000

github-actions bot pushed a commit that referenced this pull request Dec 11, 2025
@ShebMichel ShebMichel merged commit 40006f6 into datacarpentry:main Dec 12, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2025
Auto-generated via `{sandpaper}`
Source  : 40006f6
Branch  : main
Author  : ShebMichel <45086441+ShebMichel@users.noreply.github.com>
Time    : 2025-12-12 00:28:18 +0000
Message : Merge pull request #265 from abostroem/fix_episode8

Use loop_df columns instead of left_loop and right_loop
github-actions bot pushed a commit that referenced this pull request Dec 12, 2025
Auto-generated via `{sandpaper}`
Source  : c110246
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-12-12 00:29:14 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 40006f6
Branch  : main
Author  : ShebMichel <45086441+ShebMichel@users.noreply.github.com>
Time    : 2025-12-12 00:28:18 +0000
Message : Merge pull request #265 from abostroem/fix_episode8

Use loop_df columns instead of left_loop and right_loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants