Skip to content

added back in 'in' and added commas to make it a little more clear#258

Merged
ShebMichel merged 1 commit intodatacarpentry:mainfrom
abostroem:issue226
Dec 9, 2025
Merged

added back in 'in' and added commas to make it a little more clear#258
ShebMichel merged 1 commit intodatacarpentry:mainfrom
abostroem:issue226

Conversation

@abostroem
Copy link
Copy Markdown
Contributor

closes #226

#226 describes a repeated "in" and a lack of space. both of these have already been addressed - however, I believe there should be two "in". I have updated the text and added commas to try to make it a little more clear

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/astronomy-python/compare/md-outputs..md-outputs-PR-258

The following changes were observed in the rendered markdown documents:

 06-join.md | 4 ++--
 md5sum.txt | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-12-09 00:19:17 +0000

github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
@ShebMichel ShebMichel merged commit 84ddee2 into datacarpentry:main Dec 9, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
Auto-generated via `{sandpaper}`
Source  : 84ddee2
Branch  : main
Author  : ShebMichel <45086441+ShebMichel@users.noreply.github.com>
Time    : 2025-12-09 03:37:29 +0000
Message : Merge pull request #258 from abostroem/issue226

added back in 'in' and added commas to make it a little more clear
github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
Auto-generated via `{sandpaper}`
Source  : 59584a0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-12-09 03:38:20 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 84ddee2
Branch  : main
Author  : ShebMichel <45086441+ShebMichel@users.noreply.github.com>
Time    : 2025-12-09 03:37:29 +0000
Message : Merge pull request #258 from abostroem/issue226

added back in 'in' and added commas to make it a little more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space needed in the best neighbor table

2 participants