Stream closure - cancel underlying stream #12
Merged
+69
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodordelibasic-db
approved these changes
Nov 5, 2025
Signed-off-by: Danilo Najkov <danilo.najkov@databricks.com>
danilonajkov-db
force-pushed
the
bug/close-underlying-stream-on-sdk-close
branch
from
e14bb47 to
e2f4275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We noticed an issue where the underlying stream was not properly closed with the
.close()method of the sdk. This caused streams to remain active and even recovery to kick in after some time when stream was supposed to be closed.This PR addreses this by explicitly calling
.cancelon the stream in case of a stream close.How is this tested?
Added a unit test to ensure
cancelis called with a spy on the grpc stream