perf: speed up manifest JSON rendering#879
Open
He-Pin wants to merge 1 commit into
Open
Conversation
Motivation: std.manifestJson* still contributed to the local Scala Native gap versus source-built jrsonnet, especially in real-world object-heavy rendering. Modification: Add an internal StringBuilder-backed FastMaterializeJsonRenderer for std.manifestJson, std.manifestJsonMinified, and std.manifestJsonEx while preserving the public MaterializeJsonRenderer StringWriter API. Reuse an in-place codepoint key sorter backed by java.util.Arrays.sort, and fix raw-surrogate prefix ordering in compareStringsByCodepoint. Result: Full validation passed: ./mill --no-server --ticker false --color false __.reformat and ./mill --no-server --ticker false --color false -j 1 __.test reported 451/451 tests passing. JMH regressions: manifestJsonEx 0.055 ms/op, realistic2 43.596 ms/op, gen_big_object 0.842 ms/op. Direct hyperfine against source-built jrsonnet: manifestJsonEx sjsonnet-native 5.090 ms vs jrsonnet 4.075 ms; kube-prometheus sjsonnet-native 143.738 ms vs jrsonnet 97.385 ms.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std.manifestJson,std.manifestJsonMinified, andstd.manifestJsonExrouted throughjava.io.StringWriter, payingStringBuffersynchronization perwrite/flushon the hot manifestation path. Source-built jrsonnet comparisons showed sjsonnet trailing on object-heavy manifest workloads.Modification
StringBuilderWriter: an unsynchronizedWriterover aStringBuilder.FastMaterializeJsonRendererbacked byStringBuilderWriter; route the threestd.manifestJson*builtins through it. PublicMaterializeJsonRendererABI/shape unchanged.sortedVisibleKeyNames/maybeSortKeys(avoids.sortedboxing).UnicodeHandlingTestsextended.Result
Scala Native hyperfine on kube-prometheus, jrsonnet HEAD
2d7eed05:manifestJsonEx, sjsonnetTest plan
./mill __.reformat./mill 'sjsonnet.jvm[3.3.7]'.test— 518/518 passThis PR is the base for the stacked follow-ups #875 (TomlRenderer reuses
StringBuilderWriter), and the independent #876/#877/#878.