Skip to content

perf: skip builders for single-spec formats #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenamar-db merged 1 commit into from
May 11, 2026
+12 −5
Merged

perf: skip builders for single-spec formats #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sjsonnet/src/sjsonnet/Format.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,13 @@ object Format {
}
val labels = parsed.labels
val specBits = parsed.specBits
val singleSpecNoStatic = specBits.length == 1 && parsed.staticChars == 0
// Pre-size StringBuilder based on static chars + estimated dynamic content
val output = new java.lang.StringBuilder(parsed.staticChars + specBits.length * 8)
appendLeading(output, parsed)
val output =
if (singleSpecNoStatic) null
else new java.lang.StringBuilder(parsed.staticChars + specBits.length * 8)
if (!singleSpecNoStatic) appendLeading(output, parsed)
var singleFormatted: String = null
var i = 0
var idx = 0
// Use while-loop instead of for/zipWithIndex to avoid iterator allocation
Expand Down Expand Up @@ -731,8 +735,11 @@ object Format {
i += 1
formattedValue
}
output.append(cooked0)
appendLiteral(output, parsed, idx)
if (singleSpecNoStatic) singleFormatted = cooked0
else {
output.append(cooked0)
appendLiteral(output, parsed, idx)
}
idx += 1
}

Expand All @@ -741,7 +748,7 @@ object Format {
"Too many values to format: %d, expected %d".format(valuesArr.length, i)
)
}
output.toString()
if (singleSpecNoStatic) singleFormatted else output.toString()
}

/**
Expand Down
Loading