Skip to content

perf: speed up simple integer parsing #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −2
Open

perf: speed up simple integer parsing #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions sjsonnet/src/sjsonnet/Parser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,21 @@ class Parser(
true
}

private def parseSimpleUnsignedInteger(s: String): Double = {
val length = s.length
if (length == 0 || length > 18) return Double.NaN

var value = 0L
var i = 0
while (i < length) {
val digit = s.charAt(i) - '0'
if (digit < 0 || digit > 9) return Double.NaN
value = value * 10L + digit
i += 1
}
value.toDouble
}

def number[$: P]: P[Val.Num] = P(
Pos ~~ (
digitsWithSeparator ~~
Expand All @@ -160,8 +175,12 @@ class Parser(
if (hasUnderscores && !isValidNumberWithSeparators(numStr)) {
Fail.opaque("invalid underscore placement in number")
} else {
val cleanStr = if (hasUnderscores) numStr.replace("_", "") else numStr
val v = cleanStr.toDouble
val v =
if (hasUnderscores) numStr.replace("_", "").toDouble
else {
val parsed = parseSimpleUnsignedInteger(numStr)
if (parsed.isNaN) numStr.toDouble else parsed
}
if (v.isInfinite) {
Fail.opaque("finite number required")
} else {
Expand Down
Loading