perf: speed up constant string joins#825
Open
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Open
Conversation
7dd77cb to
9e7c7f1
Compare
Contributor
Author
|
Closing as superseded by #828, which carries the TOML and repeated join work with current docs-aligned benchmark data. |
Contributor
Author
|
Reopened and moved back to draft rather than closing. It is not negative, but it is currently superseded by #828, so it should not be ready for review unless we decide to keep it as a separate smaller join-only PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std.makeArray(... literal)arrays as an O(1) constant array view.std.joinover constant/repeated string arrays with exactStringBuildersizing.private[this]in touched Scala sources.Benchmarks
Baseline: latest
upstream/masterat8b67cb1e. This PR:9e7c7f13.JMH + GC profiler for
bench/resources/cpp_suite/large_string_join.jsonnet, lower is better:gc.alloc.rate.normScala Native hyperfine against latest source-built jrsonnet master
5b43fa8(jrsonnet 0.5.0-pre98), lower is better:The Native CLI run is short and outlier-heavy, but the current mean has this PR ahead of latest jrsonnet on
large_string_join. The stronger signal is the JMH runtime/allocation reduction above.Validation
./mill -i __.checkFormatgit diff --check./mill -i 'sjsonnet.jvm[3.3.7].test'./mill -i 'sjsonnet.js[3.3.7].test'./mill -i 'sjsonnet.js[3.3.7].compile' 'sjsonnet.native[3.3.7].compile'./mill -i 'sjsonnet.native[3.3.7].nativeLink'./mill -i bench.runJmh sjsonnet.bench.RegressionBenchmark.main -p path=bench/resources/cpp_suite/large_string_join.jsonnet -prof gchyperfine --warmup 10 --min-runs 50References
9e7c7f1330230966f65dbdd4a5765015b68263665b43fa88b8c43856dd5a2daa9c5c251153c5e14d