Fix Release Workflow to publish in Maven Central. #489
Conversation
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
| server-password: ${{ secrets.MAVEN_CENTRAL_PASSWORD }} | ||
| server-username: MAVEN_CENTRAL_USERNAME | ||
| server-password: MAVEN_CENTRAL_PASSWORD | ||
| gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }} |
There was a problem hiding this comment.
What is the issue with the old way?
Why it does not apply to the private key?
There was a problem hiding this comment.
I just changed this to the old behavior that we changed here. I actually can't figure out where this key is exactly used.
There was a problem hiding this comment.
The issue with the current behaviour is that the secret is passed in the format of {env.Secret}. Which corrupts the secret.
| - name: Run Release Dry-Run (Verify) | ||
| if: "!startsWith(github.ref, 'refs/tags/')" | ||
| run: mvn -Prelease -DskipTests=true --batch-mode verify | ||
| env: |
There was a problem hiding this comment.
No private key needed here?
There was a problem hiding this comment.
ditto reason.
I just changed this to the old behavior that we changed here. I actually can't figure out where this key is exactly used.
What changes are proposed in this pull request?
This fixes three things in the release workflow:
How is this tested?
Manually tested.
NO_CHANGELOG=true