Improved telemetry + error logging for token federation errors #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopalldb
reviewed
Jan 22, 2026
| return retrieveToken(hc, tokenUrl, params, headers); | ||
| } | ||
|
|
||
| private static final String TOKEN_EXCHANGE_ERROR_MESSAGE = |
Collaborator
There was a problem hiding this comment.
final string for errors is unconventional in our code. We can keep this defined once in the business logic of function, and reuse the same string again in catch block. But usually it is better to keep different error messages for errors at different places. Debugging will be easier, as from errormsg we can uniquely identify code where error occurred. So, no real incentive for reuse here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
error_name: "AUTH_ERROR" stack_trace: "Failed to retrieve the exchanged token".Failed to retrieve the exchanged token from OIDC token endpoint. HTTP request failed by code: 401, status line: HTTP/1.1 401 Unauthorized. Error message: Invalid credentials.Testing
Additional Notes to the Reviewer