cmdio: drop unused PromptOptions.AllowEdit#5177
Merged
Conversation
AllowEdit only affects how promptui renders a non-empty Default: with AllowEdit:true the default pre-fills the buffer; with AllowEdit:false it appears as a placeholder that's wiped on first keystroke. No caller in the repo sets Default, so the field has been a no-op everywhere it was passed. Drop it rather than carry an option that does nothing. Co-authored-by: Isaac
pietern
force-pushed
the
drop-prompt-allowedit
branch
from
0e2b171 to
ee81845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllowEditonly affects howpromptuirenders a non-emptyDefault: withAllowEdit:truethe default pre-fills the buffer; withAllowEdit:falseit appears as a placeholder that's wiped on first keystroke. No caller in the repo setsDefault, so the field has been a no-op everywhere it was passed. Drop it rather than carry an option that does nothing.Test plan
go build ./...go vet ./cmd/configure/... ./cmd/auth/... ./libs/cmdio/...go test ./libs/cmdio/... ./cmd/configure/... ./cmd/auth/...This pull request and its description were written by Isaac.