Remove Makefile (use ./task directly)#5167
Open
shreyas-goenka wants to merge 1 commit intomainfrom
Open
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The Makefile was a back-compat wrapper kept after #5050 for callers like `make integration`. It silently regressed (`make integration` reported "is up to date" because integration/ is a real directory) and broke the nightly cli-isolated-nightly workflow for ~5 days. Rather than patch the wrapper, drop it entirely and route every caller through ./task directly: - integration/README.md: make integration → ./task integration - experimental/ssh/README.md: make build snapshot-release → ./task ... - tools/bench_parse.py: docstring example updated Note: databricks-eng/eng-dev-ecosystem cli-isolated-tests.yml still calls `make integration|integration-short|dbr-integration`. That repo needs a parallel PR converting those to ./task before this lands, otherwise the nightly will fail with "make: No rule to make target". Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
fix-makefile-integration-target
branch
from
e5a3cd3 to
50a9b28
Compare
shreyas-goenka
changed the title
make integration silently skipping when integration/ exists
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
denik
approved these changes
May 4, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
small FYI: ./task does not work on Windows, one need to use go tool for cross-platform. But I think it's fine for docs to refer to ./task since we don't develop on Windows and tests do use "go tool"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the Makefile and route every remaining caller through `./task` directly.
#5050 introduced `./task` and kept the Makefile as a thin shim. eng-dev-ecosystem #1273 was the last external consumer; it now calls `go tool task` directly, so the shim has no callers left and can go.
The shim was also broken: `make integration` was silently exiting 0 because `integration/` is a real directory (`.DEFAULT` doesn't apply when the target name matches a file/directory). That's how cli-isolated-nightly stopped producing `output.json` for ~5 days.
Diff
No CI changes needed — `.github/workflows/` already calls `./task`.
This pull request was AI-assisted by Isaac.