Skip to content

Remove server_side_default (just to see what fails) #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
denik wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove server_side_default (just to see what fails) #4392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions bundle/direct/bundle_plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,13 +386,6 @@ func addPerFieldActions(ctx context.Context, adapter *dresources.Adapter, change
} else if shouldSkip(cfg, path, ch) {
ch.Action = deployplan.Skip
ch.Reason = deployplan.ReasonBuiltinRule
} else if ch.New == nil && ch.Old == nil && ch.Remote != nil && path.IsDotString() {
// The field was not set by us, but comes from the remote state.
// This could either be server-side default or a policy.
// In any case, this is not a change we should react to.
// Note, we only consider struct fields here. Adding/removing elements to/from maps and slices should trigger updates.
ch.Action = deployplan.Skip
ch.Reason = deployplan.ReasonServerSideDefault
} else if action := shouldUpdateOrRecreate(cfg, path); action != deployplan.Undefined {
ch.Action = action
ch.Reason = deployplan.ReasonBuiltinRule
Expand Down
Loading