Fix: Support trigger_pause_status preset in alerts
#4323
Merged
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
Collaborator
|
Commit: f913e0f
18 interesting tests: 9 KNOWN, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jan 20, 2026
pietern
changed the title
trigger_pause_status preset in alerts
Contributor
|
@shreyas-goenka Can you add a NEXT_CHANGELOG entry? |
shreyas-goenka
changed the title
trigger_pause_status preset in alertstrigger_pause_status preset in alerts
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Apply the
trigger_pause_statuspreset to SQL Alerts, similar to how it's already applied to Jobs and Pipelines.Why
Fixes #4316. SQL Alerts were ignoring the
trigger_pause_statuspreset configured at the target level, while Jobs correctly respected it. This caused alerts to remain unpaused even whentrigger_pause_status: PAUSEDwas set.Tests
Added unit tests covering:
UNPAUSED→ remains unpausedAlso, manually tested that this works as expected.