feat: add .obo conventions on sql files #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asUserAPI option with.obo.sqlfile naming convention for user-scoped query executionasUserprop from all UI components (hooks, charts, tables)Details
Convention-based execution context
Query execution context is now determined by file naming:
config/queries/<query_key>.sql→ Executes as service principal (shared cache)config/queries/<query_key>.obo.sql→ Executes as user (OBO = On-Behalf-Of, per-user cache)This is more declarative than passing
asUser: truethrough the UI layer, as the query file itself declares its execution semantics.API changes
Removed:
POST /api/analytics/users/me/query/:query_keyGET /api/analytics/users/me/arrow-result/:jobIdasUseroption fromuseAnalyticsQuery,useChartData,TableWrapper, and chart componentsUnchanged:
POST /api/analytics/query/:query_key(now handles both contexts)GET /api/analytics/arrow-result/:jobIdPlugin.asUser(req)method (still available for custom plugins)Cache behavior
.sqlqueries use global cache key (shared across all users).obo.sqlqueries use per-user cache key (isolated per user)Test plan
.sqlqueries execute as service principal.obo.sqlqueries execute as user.sqland.obo.sqlqueries.sqlqueries across users.obo.sqlqueriespnpm typecheck- no type errorspnpm test- all tests pass