Fix: require uv in prereq check instead of silent pip fallback#363
Open
jacksandom wants to merge 2 commits intomainfrom
Open
Fix: require uv in prereq check instead of silent pip fallback#363jacksandom wants to merge 2 commits intomainfrom
jacksandom wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uva hard requirement incheck_deps()— fail immediately with an actionable error message instead of silently falling back topip3/pippip/pip3fallback codepath fromsetup_mcp()sinceuvis now enforcedProblem
When
uvis not installed, the installer silently falls back topip3/pip. This causes a crypticsetup.py not foundorNo module named piperror because:pyproject.toml-only builds (nosetup.py)uvinstall doesn't includepipThe README already lists
uvas a hard prerequisite, and the sub-project setup scripts (databricks-mcp-server/setup.sh,databricks-builder-app/scripts/setup.sh) already enforce it. The maininstall.shwas the only path that didn't.Test plan
uvfrom PATH, runbash install.sh— should fail immediately with clear install instructionsuv, runbash install.sh— should pass prereq check showing uv versionCloses #351