Skip to content

feat(query): support attaching stage for insert values#9249

Merged
mergify[bot] merged 8 commits into
databendlabs:mainfrom
everpcpc:feat-insert
Dec 16, 2022
Merged

feat(query): support attaching stage for insert values#9249
mergify[bot] merged 8 commits into
databendlabs:mainfrom
everpcpc:feat-insert

Conversation

@everpcpc
Copy link
Copy Markdown
Member

@everpcpc everpcpc commented Dec 14, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Then we can obtain data from stage with the insert operation.

Closes #8889

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 16, 2022 at 7:13AM (UTC)

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label Dec 14, 2022
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Dec 14, 2022

Hi, can you give some explanation in this PR's summary? I don't know what does sideload means.

Comment thread src/query/service/src/sessions/query_ctx.rs
Comment thread src/query/catalog/src/table_context.rs Outdated
Comment thread src/query/sql/src/planner/plans/insert.rs Outdated
@everpcpc everpcpc changed the title feat(query): support sideload data for insert values feat(query): support attaching stage for insert values Dec 15, 2022
@everpcpc everpcpc force-pushed the feat-insert branch 2 times, most recently from fa2f866 to 909a01c Compare December 15, 2022 11:58
@everpcpc everpcpc marked this pull request as ready for review December 15, 2022 12:02
Comment thread src/query/service/src/servers/http/v1/query/http_query.rs Outdated
Comment thread src/query/service/src/interpreters/interpreter_insert_v2.rs
Comment thread src/query/service/src/interpreters/interpreter_insert_v2.rs Outdated
Comment thread src/query/service/src/interpreters/interpreter_insert_v2.rs Outdated
@ariesdevil
Copy link
Copy Markdown
Contributor

We need to update docs for this new way of data insertion, maybe next PR.

@youngsofun
Copy link
Copy Markdown
Member

need a stateful test, maybe next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Support pass a staged file path in the POST /v1/query args

5 participants