fix remaining deadlocks + prep deletion #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkan
changed the title
Collaborator
Author
|
a good chunk of the logic can be deleted if we decide to drop MySQL support, however I believe we do have some users on that backend |
Collaborator
Author
|
hmmm ok we have a non-deterministic deadlock in healthcheck test under mysql, investigating (this is good though, the test is meant to stress the logic) |
Collaborator
Author
|
ok this now remains stable after 100 rounds of torture, I feel pretty good about it |
added 2 commits
November 11, 2025 15:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok this ended up expanding into a pretty comprehensive set of fixes for various database related woes, supporting 3 backends with complex relations on a large DB is a bit of a pain but this should resolve both stale workers and inability to delete preparations (which seems to have been a combination of cascade deadlocks in some cases and just incredibly long running files tablescans in others)