signer,pdp: refactor AuthHelper to use SignDigestFunc#15
Merged
Conversation
EIP-712 typed-data signing for PDP extraData only needs one operation from the key holder: 'sign this 32-byte keccak digest, return 65 bytes'. Switch AuthHelper to take a SignDigestFunc instead of a raw *ecdsa.PrivateKey, and add SignDigest to the EVMSigner interface so secp256k1 signers (incl. future HSM/remote variants) can plug in without leaking private keys. - signer.EVMSigner: add SignDigest(digest []byte) ([]byte, error). V is the raw recovery ID 0/1 (go-ethereum crypto.Sign convention); callers needing the on-chain 27/28 form normalize themselves. - pdp.AuthHelper: take SignDigestFunc + signer address explicitly. Keep NewAuthHelperFromKey as a convenience for raw-key callers (tests, scripts, the existing Client.NewAuthHelper). signTypedData now calls through the func and validates the 65-byte length. - synapse.go callers updated to NewAuthHelperFromKey. Singularity's dealpusher will use NewAuthHelper(evmSigner.SignDigest, evmSigner.EVMAddress(), ...) so its keystore-backed signer never has to hand out a raw key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.