Skip to content

[PLUGIN-1950] Log warning when a table has no records to read #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psainics wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −1
Open

[PLUGIN-1950] Log warning when a table has no records to read #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/io/cdap/plugin/format/DBTableRecordReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import org.apache.hadoop.mapreduce.InputSplit;
import org.apache.hadoop.mapreduce.RecordReader;
import org.apache.hadoop.mapreduce.TaskAttemptContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.sql.Connection;
Expand All @@ -38,6 +40,7 @@
* Record reader that reads the entire contents of a database table using JDBC.
*/
public class DBTableRecordReader extends RecordReader<NullWritable, RecordWrapper> {
private static final Logger LOG = LoggerFactory.getLogger(DBTableRecordReader.class);
private final DBTableName tableName;
private final String tableNameField;
private final MultiTableConf dbConf;
Expand Down Expand Up @@ -85,6 +88,10 @@ public boolean nextKeyValue() throws IOException {
schema = Schema.recordOf(tableName.getTable(), schemaFields);
}
if (!results.next()) {
if (pos == 0) {
LOG.warn("Split for table '{}' returned no records. Split query: '{}'",
tableName.getTable(), getQuery());
}
return false;
}

Expand Down
4 changes: 3 additions & 1 deletion src/main/java/io/cdap/plugin/format/SQLStatementRecordReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import io.cdap.cdap.api.data.format.StructuredRecord;
import io.cdap.cdap.api.data.schema.Schema;
import io.cdap.plugin.DriverCleanup;
import io.cdap.plugin.format.error.collector.ErrorCollectingMultiSQLStatementInputFormat;
import org.apache.hadoop.io.NullWritable;
import org.apache.hadoop.mapreduce.InputSplit;
import org.apache.hadoop.mapreduce.RecordReader;
Expand Down Expand Up @@ -89,6 +88,9 @@ public boolean nextKeyValue() throws IOException {
schema = Schema.recordOf(tableName, schemaFields);
}
if (!results.next()) {
if (pos == 0) {
LOG.warn("SQL statement '{}' returned no records.", split.getSqlStatement());
}
return false;
}

Expand Down