Added BigQuery capability to BigQuery SQL Engine #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernst
force-pushed
the
add-bigquery-sql-string-expression-factory-type
branch
from
081eb67 to
b0232c5
Compare
tivv
reviewed
Apr 11, 2022
src/main/java/io/cdap/plugin/gcp/bigquery/relational/SQLExpressionFactory.java
Show resolved
Hide resolved
fernst
force-pushed
the
add-bigquery-sql-string-expression-factory-type
branch
from
b0232c5 to
15d19c7
Compare
fernst
changed the title
tivv
reviewed
Apr 12, 2022
| @Override | ||
| public Set<Capability> getCapabilities() { | ||
| return new HashSet<>(Arrays.asList(StringExpressionFactoryType.SQL, | ||
| StandardSQLCapabilities.BIGQUERY, |
Contributor
There was a problem hiding this comment.
nit: given this grows up, it makes sense to make it a constant
Contributor
There was a problem hiding this comment.
Please update javadoc, it does not reflect the implementation anymore
fernst
force-pushed
the
add-bigquery-sql-string-expression-factory-type
branch
from
15d19c7 to
eabe06c
Compare
tivv
approved these changes
Apr 12, 2022
fernst
force-pushed
the
add-bigquery-sql-string-expression-factory-type
branch
from
eabe06c to
67de98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on cdapio/cdap#14178