[PLUGIN-869] Added execution metrics for BQ Pushdown jobs #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Validates stages for a Join on Key operation | ||
| * | ||
| * <p> |
Contributor
There was a problem hiding this comment.
nit: is this intentional?
tivv
reviewed
Mar 16, 2022
| " Start: {} ,\n" + | ||
| " End: {} ,\n" + | ||
| " Execution time: {} ,\n" + | ||
| " Processed Bytes: {} ,\n" + |
Contributor
There was a problem hiding this comment.
Could you also log numDmlAffectedRows? I think it should be more or less corresponding to output rows and we mostly talk about rows in CDAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace logging for additional metrics can be enabled by configuring
io.cdap.plugin.gcp.bigquery.sqlengine.util.BigQuerySQLEngineUtilstoTRACElog level