Skip to content

fix comments in BigQueryDataParser.java #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glitched-w0rld wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix comments in BigQueryDataParser.java #1438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/io/cdap/plugin/gcp/bigquery/util/BigQueryDataParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ public static StructuredRecord getStructuredRecord(Schema schema, FieldList fiel
FieldList subFields = field.getSubFields();

if (attribute == Attribute.REPEATED) {
// Process each field of the array and then add it to the StructuredRecord
// Process each field of the array, then add it to the StructuredRecord
List<Object> list = new ArrayList<>();
List<FieldValue> fieldValueList = fieldValue.getRepeatedValue();

for (FieldValue localValue : fieldValueList) {
// If the field contains multiple fields then we have to process it recursively.
// If the field contains multiple fields, it must be processed recursively.
if (localValue.getValue() instanceof FieldValueList) {
FieldValueList localFieldValueListNoSchema = localValue.getRecordValue();
FieldValueList localFieldValueList =
Expand All @@ -105,7 +105,7 @@ public static StructuredRecord getStructuredRecord(Schema schema, FieldList fiel
recordBuilder.set(fieldName, list);

} else if (attribute == Attribute.RECORD) {
// If the field contains a Record then we need to process each field independently
// If the field contains a Record, each field must be processed independently.
FieldValue localValue = fieldValue;
Object value;
if (localValue.getValue() instanceof FieldValueList) {
Expand Down