Changes done for adding formats to the Azure Blob Storage plugin#163
Open
vikasrathee-cs wants to merge 1 commit into
Open
Changes done for adding formats to the Azure Blob Storage plugin#163vikasrathee-cs wants to merge 1 commit into
vikasrathee-cs wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Azure Blob Store batch source to support Azure Data Lake Storage Gen2 (ABFS) alongside WASB, introducing new authentication methods such as Service Principal and Managed Identity. The implementation is updated to extend AbstractFileSource instead of AbstractFileBatchSource, with corresponding updates to documentation, dependencies, and UI widgets. The review feedback highlights critical safety improvements, specifically pointing out potential NullPointerException risks when validating or parsing null path and account values, as well as identifying obsolete UI widgets that should be removed.
vikasrathee-cs
force-pushed
the
guava-cdap-ui-fix
branch
from
ea61df6 to
726e15a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes done for adding formats to the Azure Blob Storage plugin