Conversation
petrkalos
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
There is a new vulnerability found in the package
ip. Similar to the one that we faced a couple of months ago (check this PR). In fact the CVE opened now is the result of the old vulnerability being only partially fixed.There is not a fixed version and there are no PRs open in the original repo. There is not much activity happening in this repository, so a fix might take some time. At the same time, we do not use this package directly, it is a sub-dependency from react-native packages. Since
node_modules/@react-native-community/cliversion: 13.6.6, does not useip, the easiest way for us to avoid this issue is to upgrade react-native packages.In addition, this PR removes an expired ignore for npm-audit.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.