Add support for scalar arguments to xp.where#78
Conversation
|
Some of this overlaps with the stuff I've done over at #82, although I haven't implemented any scalar stuff there yet because it isn't in the standard yet. |
1b21b2c to
d9a6b73
Compare
ev-br
left a comment
There was a problem hiding this comment.
I'd think it should allow complex x1 and x2, too. Here and in the annotation.
LGTM otherwise!
ev-br
left a comment
There was a problem hiding this comment.
There's a conflict now, could you please resolve it?
Also, the spec requires that at least one of x1 and x2 is an array. IIUC, this PR allows both of them to be python scalars. As long as this repo is scrupulous in implementing the spec, it should probably check and error out if both are scalars?
|
A small update to make it adhere to the spec to the letter: betatim#1 |
|
Thanks for the PR @ev-br If you'd like to take over the original PR (this PR) to get it done that would be awesome. |
|
Happy to oblige @betatim --- thank you! |
This is related to data-apis/array-api#807
This only adds support for scalars to
where(). If the second or third argument is a scalar it is turned into an array on the same device ascondition.I added
2024.12asnext_supported_version. This means we can use it in the tests. Not sure if we use some kind of dummy value instead of 2024.12?