MAINT: make __str__ less ambiguous#114
Merged
ev-br merged 1 commit intodata-apis:mainfrom Jan 7, 2025
Merged
Conversation
For 0D arrays, __str__ used to look like a scalar: In [2]: x = xp.asarray(3) In [3]: print(x) 3 So make it clearly an array.
lucascolley
approved these changes
Dec 26, 2024
Member
Author
|
One vote in favor, no other comments, let's land this. Thanks Lucas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 0D arrays,
__str__used to look confusingly like a scalar, make it clearly an array instead.Before:
This PR: