Closed
Conversation
Reduce memory spikes during data transfer with `test_rebalance`, by using NumPy arrays (zero-copy) and more, smaller keys. Fixes dask#5688
Collaborator
Author
|
@crusaderky this still failed once: https://github.com/dask/distributed/runs/4927021521?check_suite_focus=true#step:12:1626 But in stderr for that test, there's no longer anything about unmanaged memory use being high, or the worker pausing or restarting. So is it possible that the |
Collaborator
Author
|
Note that with #5695, this may not be necessary. However, the fact that it was so sensitive to a 10mb change in worker memory means it probably should be made less sensitive anyway. |
Collaborator
Collaborator
|
Superseded by #5697 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce memory spikes during data transfer with
test_rebalance, by using NumPy arrays (zero-copy) and more, smaller keys.pre-commit run --all-files