Conversation
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for contributing this, I've never heard of fly.io. I'm happy to merge this in but I don't think I'll be much help in maintaining it so if issues come up I'll ping you on them.
I noticed you copied in the whole SDK rather than adding it as a dependency. Can I ask why?
| "digitalocean": ["python-digitalocean>=1.15.0"], | ||
| "gcp": ["google-api-python-client>=1.12.5", "google-auth>=1.23.0"], | ||
| "hetzner": ["hcloud>=1.10.0"], | ||
| "fly": ["httpx>=0.24.0", "pydantic>=1.10.7"], |
There was a problem hiding this comment.
Shouldn't this include fly-python-sdk?
I'm not in control over that repo, and it isn't clear how much if any effort will be spent in the future by the maintainer to update or fix issues, so I figured the most reliable thing to do, especially for such a small subset of the Fly API, is to implement those calls myself |
|
Just want to check in here and see if there is any interest in continuing with this PR? |
2 participants
Hello! This PR adds the cloud platform host Fly.io as a provider. It includes the auto-generated documentation too.
Let me know if anything is missing. Thank you!