Skip to content

refactor: avoid rebuilding script_pubkeys for BIP158 filter matching #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xdustinface wants to merge 1 commit into
base: dev
Choose a base branch
from

refactor: avoid rebuilding `script_pubkey`s for BIP158 filter matching

dd4558c
Select commit
Loading
Failed to load commit list.
Open

refactor: avoid rebuilding script_pubkeys for BIP158 filter matching #781

refactor: avoid rebuilding `script_pubkey`s for BIP158 filter matching
dd4558c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 1s

72.19% (-0.50%) compared to 4af39af

View this Pull Request on Codecov

72.19% (-0.50%) compared to 4af39af

Details

Codecov Report

❌ Patch coverage is 76.36364% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.19%. Comparing base (4af39af) to head (dd4558c).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...allet/managed_wallet_info/wallet_info_interface.rs 0.00% 7 Missing ⚠️
key-wallet-manager/src/process_block.rs 16.66% 5 Missing ⚠️
...-wallet/src/managed_account/managed_account_ref.rs 0.00% 5 Missing ⚠️
key-wallet/src/managed_account/address_pool.rs 0.00% 3 Missing ⚠️
...allet/src/managed_account/managed_account_trait.rs 0.00% 3 Missing ⚠️
...wallet/src/managed_account/managed_account_type.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #781      +/-   ##
==========================================
- Coverage   72.69%   72.19%   -0.50%     
==========================================
  Files         321      321              
  Lines       70350    70396      +46     
==========================================
- Hits        51140    50822     -318     
- Misses      19210    19574     +364
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 83.39% <100.00%> (-0.19%) ⬇️
dash-spv/src/sync/blocks/manager.rs 96.93% <100.00%> (ø)
dash-spv/src/sync/events.rs 93.61% <100.00%> (ø)
dash-spv/src/sync/filters/batch.rs 97.60% <100.00%> (ø)
dash-spv/src/sync/filters/manager.rs 97.50% <100.00%> (ø)
dash-spv/src/sync/filters/sync_manager.rs 100.00% <ø> (ø)
dash-spv/src/sync/mempool/sync_manager.rs 98.72% <100.00%> (ø)
key-wallet-manager/src/lib.rs 75.80% <ø> (ø)
key-wallet-manager/src/matching.rs 95.83% <100.00%> (+0.18%) ⬆️
key-wallet-manager/src/wallet_interface.rs 15.00% <100.00%> (ø)
... and 6 more

... and 24 files with indirect coverage changes

View more details on Codecov