Skip to content

chore(ci): require Python 3.12+ check at script start#760

Open
ZocoLini wants to merge 1 commit into
v0.42-devfrom
chore/setup-dashd-python-version-check
Open

chore(ci): require Python 3.12+ check at script start#760
ZocoLini wants to merge 1 commit into
v0.42-devfrom
chore/setup-dashd-python-version-check

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

tarfile.extractall(..., filter="data") is only available on Python 3.12+. Failing fast with a clear message avoids a cryptic mid-download TypeError when the script is run on an older interpreter

`tarfile.extractall(..., filter="data")` is only available on Python
3.12+. Failing fast with a clear message avoids a cryptic mid-download
`TypeError` when the script is run on an older interpreter.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ZocoLini ZocoLini requested a review from xdustinface May 12, 2026 22:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Warning

Rate limit exceeded

@ZocoLini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 43 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01b55d9a-f281-454d-a506-5ac32fba7a48

📥 Commits

Reviewing files that changed from the base of the PR and between 5297d61 and 6f32856.

📒 Files selected for processing (1)
  • contrib/setup-dashd.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/setup-dashd-python-version-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.26%. Comparing base (5297d61) to head (6f32856).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #760      +/-   ##
=============================================
- Coverage      72.26%   72.26%   -0.01%     
=============================================
  Files            320      320              
  Lines          70275    70275              
=============================================
- Hits           50785    50784       -1     
- Misses         19490    19491       +1     
Flag Coverage Δ
core 76.30% <ø> (ø)
ffi 46.10% <ø> (+0.01%) ⬆️
rpc 20.00% <ø> (ø)
spv 89.74% <ø> (-0.02%) ⬇️
wallet 71.26% <ø> (ø)
see 3 files with indirect coverage changes

Copy link
Copy Markdown
Collaborator

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. It was added in 3.12 but backported to 3.8.17, 3.9.17, 3.10.12 (which is whats running on some CI runners and was running fine ever since on the dev branch) and 3.11.4.

What version did you use when you run into this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants