Chore: reputation cleanup

dash-spv/src/client/chainlock.rs

@@ -43,8 +43,7 @@ impl<
                 .await
             {
                 // Penalize the peer that relayed the invalid ChainLock
-                let reason = format!("Invalid ChainLock: {}", e);
-                let _ = self.network.penalize_last_message_peer_invalid_chainlock(&reason).await;
+                let _ = self.network.penalize_last_message_peer_invalid_chainlock().await;
                 return Err(SpvError::Validation(e));
             }
         }
@@ -111,7 +110,7 @@ impl<
             tracing::warn!("{}", reason);
 
             // Ban the peer using the reputation system
-            let _ = self.network.penalize_last_message_peer_invalid_instantlock(&reason).await;
+            let _ = self.network.penalize_last_message_peer_invalid_instantlock().await;
 
             return Err(SpvError::Validation(e));
         }

dash-spv/src/client/queries.rs

@@ -42,20 +42,6 @@ impl<
         self.network.peer_count()
     }
 
-    /// Disconnect a specific peer.
-    pub async fn disconnect_peer(&self, addr: &std::net::SocketAddr, reason: &str) -> Result<()> {
-        // Cast network manager to PeerNetworkManager to access disconnect_peer
-        let network = self
-            .network
-            .as_any()
-            .downcast_ref::<crate::network::manager::PeerNetworkManager>()
-            .ok_or_else(|| {
-                SpvError::Config("Network manager does not support peer disconnection".to_string())
-            })?;
-
-        network.disconnect_peer(addr, reason).await
-    }
-
     // ============ Masternode Queries ============
 
     /// Get a reference to the masternode list engine.

dash-spv/src/network/mod.rs

@@ -7,7 +7,7 @@ pub mod handshake;
 pub mod manager;
 pub mod peer;
 pub mod pool;
-pub mod reputation;
+mod reputation;
 
 #[cfg(test)]
 mod tests;
@@ -17,13 +17,14 @@ pub mod mock;
 
 use async_trait::async_trait;
 
-use crate::error::NetworkResult;
+use crate::{error::NetworkResult, network::reputation::ReputationChangeReason};
 use dashcore::network::message::NetworkMessage;
 use dashcore::BlockHash;
 
 pub use handshake::{HandshakeManager, HandshakeState};
 pub use manager::PeerNetworkManager;
 pub use peer::Peer;
+pub use reputation::PeerReputation;
 
 /// Network manager trait for abstracting network operations.
 #[async_trait]
@@ -129,33 +130,18 @@ pub trait NetworkManager: Send + Sync {
     /// Default implementation is a no-op for managers without reputation.
     async fn penalize_last_message_peer(
         &self,
-        _score_change: i32,
-        _reason: &str,
+        _reason: ReputationChangeReason,
     ) -> NetworkResult<()> {
         Ok(())
     }
 
     /// Convenience: penalize last peer for an invalid ChainLock.
-    async fn penalize_last_message_peer_invalid_chainlock(
-        &self,
-        reason: &str,
-    ) -> NetworkResult<()> {
-        self.penalize_last_message_peer(
-            crate::network::reputation::misbehavior_scores::INVALID_CHAINLOCK,
-            reason,
-        )
-        .await
+    async fn penalize_last_message_peer_invalid_chainlock(&self) -> NetworkResult<()> {
+        self.penalize_last_message_peer(ReputationChangeReason::InvalidChainLock).await
     }
 
     /// Convenience: penalize last peer for an invalid InstantLock.
-    async fn penalize_last_message_peer_invalid_instantlock(
-        &self,
-        reason: &str,
-    ) -> NetworkResult<()> {
-        self.penalize_last_message_peer(
-            crate::network::reputation::misbehavior_scores::INVALID_INSTANTLOCK,
-            reason,
-        )
-        .await
+    async fn penalize_last_message_peer_invalid_instantlock(&self) -> NetworkResult<()> {
+        self.penalize_last_message_peer(ReputationChangeReason::InvalidInstantLock).await
     }
 }