Skip to content

fix: single file handle in atomic_write #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 1 commit into from
Dec 31, 2025
Merged

fix: single file handle in atomic_write #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions dash-spv/src/storage/io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
use std::path::{Path, PathBuf};

use crate::error::{StorageError, StorageResult};
use tokio::io::AsyncWriteExt;

/// Get the temporary file path for atomic writes.
/// Uses process ID and a counter to ensure uniqueness even with concurrent writes.
Expand Down Expand Up @@ -32,10 +33,8 @@ pub(crate) async fn atomic_write(path: &Path, data: &[u8]) -> StorageResult<()>

// Write to temporary file
let write_result = async {
tokio::fs::write(&temp_path, data).await?;

// Sync to disk - open the file and call sync_all
let file = tokio::fs::File::open(&temp_path).await?;
let mut file = tokio::fs::File::create(&temp_path).await?;
file.write_all(data).await?;
file.sync_all().await?;

Ok::<(), std::io::Error>(())
Expand Down