chore: bump rust-dashcore to 58d61ea#3757
Conversation
Pulls in two upstream changes: - add downgrade_to_external_signable method to wallets (dashpay/rust-dashcore#782) - feat: devnet support for dash-spv (dashpay/rust-dashcore#784) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the workspace dependencies in ChangesWorkspace Dependency Revision Pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Mechanical bump of the shared rust-dashcore git revision across 8 workspace dependencies with corresponding Cargo.lock updates. Both agents independently found no in-scope issues, and the changes are uniform and consistent with the stated intent.
Issue being fixed or feature implemented
Bumps the
rust-dashcoreworkspace dependency revision fromf569e7b7to58d61ea5(currentdevHEAD).What was done?
Updated the
revof all 8rust-dashcoreworkspace dependencies inCargo.toml(dashcore,dash-network-seeds,dash-spv,key-wallet,key-wallet-ffi,key-wallet-manager,dash-network,dashcore-rpc) and regeneratedCargo.lock.Picks up two upstream commits:
downgrade_to_external_signablemethod to walletsdash-spvHow Has This Been Tested?
cargo update -p dashcore -p dash-network-seeds -p dash-spv -p key-wallet -p key-wallet-ffi -p key-wallet-manager -p dash-network -p dashcore-rpccargo check --workspace --tests --all-features— finishes with no errorsBreaking Changes
None.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit