Skip to content

chore: bump rust-dashcore to 58d61ea#3757

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
chore/bump-rust-dashcore-58d61ea
May 27, 2026
Merged

chore: bump rust-dashcore to 58d61ea#3757
QuantumExplorer merged 1 commit into
v3.1-devfrom
chore/bump-rust-dashcore-58d61ea

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented May 27, 2026

Issue being fixed or feature implemented

Bumps the rust-dashcore workspace dependency revision from f569e7b7 to 58d61ea5 (current dev HEAD).

What was done?

Updated the rev of all 8 rust-dashcore workspace dependencies in Cargo.toml (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) and regenerated Cargo.lock.

Picks up two upstream commits:

How Has This Been Tested?

  • cargo update -p dashcore -p dash-network-seeds -p dash-spv -p key-wallet -p key-wallet-ffi -p key-wallet-manager -p dash-network -p dashcore-rpc
  • cargo check --workspace --tests --all-features — finishes with no errors

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated core dependencies to the latest versions.

Review Change Stack

Pulls in two upstream changes:
- add downgrade_to_external_signable method to wallets (dashpay/rust-dashcore#782)
- feat: devnet support for dash-spv (dashpay/rust-dashcore#784)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v3.1.0 milestone May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc61f2c8-d238-46c6-a82f-8bcdf2e77449

📥 Commits

Reviewing files that changed from the base of the PR and between a29f1c0 and 0eb3fa0.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

This PR updates the workspace dependencies in Cargo.toml to point eight crates from the dashpay/rust-dashcore repository to a new common git revision. The affected dependencies are dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, and dashcore-rpc.

Changes

Workspace Dependency Revision Pinning

Layer / File(s) Summary
Update rust-dashcore dependency revisions
Cargo.toml
Eight workspace dependencies are pinned to git revision 58d61ea50ac4c217c8e1350b57363b351a0b99d4: dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, and dashcore-rpc.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • shumkov

Poem

🐰 A bundle of deps, all aligned in a row,
Eight crates now pointing where newer winds blow,
Revision pinned tight, from rust-dashcore's keep,
Your workspace dependencies, safe and quite deep! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore: bump rust-dashcore to 58d61ea' accurately reflects the main change—updating rust-dashcore dependencies to a specific revision. It's concise, specific, and clearly communicates the primary purpose of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-rust-dashcore-58d61ea

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer merged commit a1bca5b into v3.1-dev May 27, 2026
17 of 18 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/bump-rust-dashcore-58d61ea branch May 27, 2026 18:51
Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Mechanical bump of the shared rust-dashcore git revision across 8 workspace dependencies with corresponding Cargo.lock updates. Both agents independently found no in-scope issues, and the changes are uniform and consistent with the stated intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants