fix(dpp): report correct values in IdentityInsufficientBalanceError

[pauldelucia]

Issue being fixed or feature implemented

We were passing the attempted transfer amount as the "required amount" in the error message rather than the actual required amount.

What was done?

Fix the error messages.

How Has This Been Tested?

CI

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes
  • Corrected insufficient-balance error reporting to include the full total required amount (fees plus amounts removed or withdrawn), improving clarity on why identity credit operations fail.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Three validation routines were changed to pass the computed total required balance (including fees or removed amounts) into IdentityInsufficientBalanceError, replacing previously passed original amount/balance values.

Changes

Cohort / File(s)	Summary
Identity Credit Transfer Fee Validation packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/state_transition_estimated_fee_validation.rs	IdentityInsufficientBalanceError construction updated to pass required_total (total required funding including fee) instead of self.amount().
Identity Credit Withdrawal Fee Validation packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/state_transition_estimated_fee_validation.rs	IdentityInsufficientBalanceError construction updated to pass required_total (withdrawal amount plus required fee) instead of self.amount().
Platform Events Fee Validation (Paid event) packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/validate_fees_of_event/v0/mod.rs	In the Paid event path, IdentityInsufficientBalanceError now receives total_required (computed as required_balance + removed_balance) instead of only required_balance.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing error reporting in IdentityInsufficientBalanceError to display correct values instead of incorrect amounts.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/amount-error

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e533efa and 43f57ca.

📒 Files selected for processing (1)

• packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/validate_fees_of_event/v0/mod.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/validate_fees_of_event/v0/mod.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[QuantumExplorer]

@pauldelucia some tests are failing

[QuantumExplorer]

tests are failing