fix: handle case of empty giftcard list

[HashEngineering]

Summary by CodeRabbit

• Bug Fixes
  • Fixed a potential crash in the gift card selection process by improving error handling when no cards are available.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b0f9deeb-a2a4-4b55-b80d-5dd65ca48510

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb6069 and be9c77a.

📒 Files selected for processing (1)

• src/main/kotlin/org/dash/mobile/explore/sync/process/PiggyCardsDataSource.kt

---

📝 Walkthrough

Walkthrough

This change fixes potential crash handling in gift card selection logic. The modification replaces a null-safe fallback with an explicit non-null and non-empty check before computing maximum discount, preventing NoSuchElementException on empty collections.

Changes

Cohort / File(s)	Summary
Gift Card Selection Logic src/main/kotlin/org/dash/mobile/explore/sync/process/PiggyCardsDataSource.kt	Added explicit non-empty validation before finding max discount. Prevents NoSuchElementException by checking giftCards is non-null and non-empty; returns null if conditions aren't met.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A null check here, a guard there,
No crashes in the card affair!
When lists run empty, we gracefully fall,
A safer discount for one and all! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: handling the empty giftcard list case by adding an explicit non-empty check instead of relying on null-safe fallbacks.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/handle-empty-cardlist

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}