backport: Merge bitcoin#28486, 28969, 27921, 27177, 26331

[vijaydasmp]

What was done?

Backports from Bitcoin Core

How Has This Been Tested?

Run unit & functional tests

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[coderabbitai]

Walkthrough

This pull request introduces several independent enhancements across different components: adds a HaveCoin method to CCoinsViewErrorCatcher with a centralized error-handling wrapper pattern in the coin handling logic; implements a periodic disk-space monitoring task in initialization that checks every 5 minutes and triggers shutdown if space is critical; refactors networking setup in tests to use a static initialization pattern; adds memory constraints to fuzzing targets; marks SetupNetworking() as [[nodiscard]]; and consolidates test setup steps in functional tests. Changes span core logic, initialization, testing infrastructure, and fuzzing harnesses.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title lists multiple Bitcoin Core PR numbers being backported but doesn't clearly describe the primary objective or main changes, making it difficult to understand at a glance.	Consider a more descriptive title that highlights the main purpose, such as 'Backport Bitcoin Core network initialization, fuzz hardening, and disk-space checks' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is minimally related to the changeset, mentioning backports from Bitcoin Core and test execution, though it lacks detail about specific changes being backported.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use Clang for C/C++ static analysis and code quality checks.

Clang provides comprehensive static analysis for C and C++ code, including syntax checking, type checking, and various warning diagnostics.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/init.cpp`:
- Around line 1554-1555: The code sets min_disk_space = 50 << 20 and then calls
CheckDiskSpace(args.GetBlocksDirPath(), min_disk_space), but CheckDiskSpace
already enforces a 50 MiB minimum, effectively doubling the threshold; fix by
calling CheckDiskSpace with zero additional bytes (or remove the extra
min_disk_space) so only the built-in 50 MiB minimum applies—update the call site
that uses CheckDiskSpace(args.GetBlocksDirPath(), ...) and remove or replace the
min_disk_space argument accordingly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 02873299-f29c-48b9-ac4f-09100b36a1e8

📥 Commits

Reviewing files that changed from the base of the PR and between 26aab22 and 94e4d3f.

📒 Files selected for processing (9)

• src/coins.cpp
• src/coins.h
• src/init.cpp
• src/test/fuzz/transaction.cpp
• src/test/util/setup_common.cpp
• src/test/util_tests.cpp
• src/util/system.h
• src/wallet/test/fuzz/notifications.cpp
• test/functional/mempool_package_limits.py

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Disk-space threshold is effectively doubled.

At Line 1555, CheckDiskSpace() already applies a built-in 50 MiB minimum. Passing min_disk_space from Line 1554 as additional_bytes raises the effective shutdown threshold to ~100 MiB.

💡 Proposed fix

-        constexpr uint64_t min_disk_space = 50 << 20; // 50 MB
-        if (!CheckDiskSpace(args.GetBlocksDirPath(), min_disk_space)) {
+        if (!CheckDiskSpace(args.GetBlocksDirPath())) {
             LogPrintf("Shutting down due to lack of disk space!\n");
             StartShutdown();
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/init.cpp` around lines 1554 - 1555, The code sets min_disk_space = 50 <<
20 and then calls CheckDiskSpace(args.GetBlocksDirPath(), min_disk_space), but
CheckDiskSpace already enforces a 50 MiB minimum, effectively doubling the
threshold; fix by calling CheckDiskSpace with zero additional bytes (or remove
the extra min_disk_space) so only the built-in 50 MiB minimum applies—update the
call site that uses CheckDiskSpace(args.GetBlocksDirPath(), ...) and remove or
replace the min_disk_space argument accordingly.

[thepastaclaw]

Code Review

This backport PR cleanly includes 5 of the 7 upstream Bitcoin Core PRs listed in the title (bitcoin#28486, bitcoin#28969, bitcoin#27921, bitcoin#27177, bitcoin#26331). All included backports are faithfully adapted to the Dash codebase. However, bitcoin#26118 and bitcoin#28035 are absent from the branch despite being listed in the PR title — the PR title should be corrected or the missing backports added.

Reviewed commit: 94e4d3f

🟡 1 suggestion(s)

1 additional finding

🟡 suggestion: PR title lists 7 upstream backports but only 5 are included

The PR title references bitcoin#26118 (log: Use steady clock for bench logging) and bitcoin#28035 (test: Ignore UTF-8 errors in assert_debug_log), but neither has a corresponding merge commit on this branch. Verified: src/validation.cpp still defines MICRO/MILLI macros and uses GetTimeMicros() for benchmark logging (unchanged from pre-bitcoin#26118 state), src/util/time.h lacks the MillisecondsDouble alias introduced by bitcoin#26118, and test_node.py:assert_debug_log still opens debug.log in text mode without errors='replace' (unchanged from pre-bitcoin#28035 state). The 5 included backports (bitcoin#28486, bitcoin#28969, bitcoin#27921, bitcoin#27177, bitcoin#26331) are all clean. Either update the PR title to list only the 5 included PRs, or add the missing two backports.

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `None`:
- [SUGGESTION] line None: PR title lists 7 upstream backports but only 5 are included
  The PR title references bitcoin#26118 (log: Use steady clock for bench logging) and bitcoin#28035 (test: Ignore UTF-8 errors in assert_debug_log), but neither has a corresponding merge commit on this branch. Verified: `src/validation.cpp` still defines `MICRO`/`MILLI` macros and uses `GetTimeMicros()` for benchmark logging (unchanged from pre-#26118 state), `src/util/time.h` lacks the `MillisecondsDouble` alias introduced by #26118, and `test_node.py:assert_debug_log` still opens debug.log in text mode without `errors='replace'` (unchanged from pre-#28035 state). The 5 included backports (#28486, #28969, #27921, #27177, #26331) are all clean. Either update the PR title to list only the 5 included PRs, or add the missing two backports.