[infra] relax ELB health check settings for faucet and insight

[vivekgsharma]

• Increase timeout from 3s to 10s
• Increase interval from 20s to 60s
• Increase unhealthy threshold from 2 to 5

This prevents intermittent 503s during high load or slow responses.

Summary by CodeRabbit

• Chores
  • Updated load balancer health check parameters to enhance service resilience. Extended health check intervals to 60 seconds with longer timeout windows and increased failure tolerance thresholds.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updated health check configuration values for two AWS Elastic Load Balancer resources. Modified interval from 20 to 60, timeout from 3 to 10, and unhealthy_threshold from 2 to 5 for both the web and insight load balancers.

Changes

Cohort / File(s)	Summary
ELB Health Check Configuration terraform/aws/main.tf	Updated health check parameters for aws_elb.web and aws_elb.insight: interval 20→60, timeout 3→10, unhealthy_threshold 2→5

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The load balancers now take a breath,
Health checks spaced further apart,
No rush to declare instance death—
Patient wisdom from the start! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: relaxing ELB health check settings for the web and insight load balancers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch vivek/faucet-terraform-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

terraform/aws/main.tf (1)

136-142: Approve syntax, but clarify operational implications of slower health detection.

The configuration changes are syntactically correct and align with the PR objective. However, this substantially alters the health check responsiveness:

• Old behavior: ~40 seconds to mark unhealthy (2 failures × 20s interval)
• New behavior: ~300 seconds to mark unhealthy (5 failures × 60s interval)

This 7.5× increase in detection latency trades faster failover for reduced false positives during traffic spikes. Ensure that incident response procedures and alerting rules account for this longer remediation window.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ab69db and 038376c.

📒 Files selected for processing (1)

• terraform/aws/main.tf (2 hunks)

🔇 Additional comments (1)

terraform/aws/main.tf (1)

180-186: Configuration mirrors web load balancer consistently.

The insight ELB's health check updates match the web ELB identically, maintaining configuration symmetry across both resources. This is appropriate since both serve similar purposes (external-facing HTTP/HTTPS endpoints).

Before merging, confirm:

1. These changes have been validated in a staging environment under load conditions.
2. Runbooks and alerting thresholds have been updated to reflect the ~300-second detection window.
3. The 10-second timeout is based on actual p95+ response time metrics for faucet and insight services.

[ktechmidas]

LGTM